feat: expose tcp_nodelay for clients and servers #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucioFranco
approved these changes
Nov 25, 2019
|
Thanks for this |
alce
force-pushed
the
set-no-delay
branch
2 times, most recently
from
7778aa6
to
6028aaf
Compare
|
if we can rebase this with master then we can merge this thanks! |
LucioFranco
reviewed
Dec 6, 2019
| @@ -80,7 +80,7 @@ tower = { git = "https:/tower-rs/tower" } | |||
| # Required for routeguide | |||
| serde = { version = "1.0", features = ["derive"] } | |||
| serde_json = "1.0" | |||
| rand = "0.7.2" | |||
| rand = "0.6" | |||
There was a problem hiding this comment.
Sorry, didn't see this. Because at the time I wrote this, some other dependency (some tokio sub-crate, I think) wall pulling in 0.6, so I changed it to match.
There was a problem hiding this comment.
I guess once 0.1 is close to finished we can sweep through all deps and remove what is not essential.
rabbitinspace
pushed a commit
to satelit-project/tonic
that referenced
this pull request
Jan 1, 2020
* expose tcp_nodelay * do not depend on difference versions of rand
brentalanmiller
pushed a commit
to brentalanmiller/tonic
that referenced
this pull request
Oct 6, 2023
* add: take_io method to LazyConfigAcceptor The `take_io` method can be used to take back ownership of the client IO stream when an error occurs during clientHello handshake. An example of this is when a client tries to connect to an TLS socket expecting it to be plain text connection. In this case take_io can be used to send a 400 response, "The plain HTTP request was sent to HTTPS port", back to the client. * rename test lazy_config_acceptor_take_io
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #119